Make common cache typed with generics #2896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making typed common cache so that we dont use wrong types across set/get methods and more higher level methods can be defined for cache. Currently, we are not able to operate over all keys of cache due to generic types. Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2896 +/- ##
==========================================
+ Coverage 46.68% 46.72% +0.04%
==========================================
Files 215 215
Lines 22551 22511 -40
==========================================
- Hits 10527 10519 -8
+ Misses 10668 10637 -31
+ Partials 1356 1355 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sahil-lakhwani
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making typed common cache with generics so that we don't use wrong types
across set/get methods and more higher level methods can be
defined for the cache.
Currently, we are not able to operate over all keys of the cache due to generic types.
Primary changes made in pkg/cache/cache.go
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: