Set default package status to none if deployment exists #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If package has deployment already, we should set package status to none instead of pending. If we have package has source, we set status to pending. If both source and deployment are empty, package marked as failure. Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
- Coverage 46.68% 46.66% -0.02%
==========================================
Files 215 215
Lines 22551 22559 +8
==========================================
Hits 10527 10527
- Misses 10668 10676 +8
Partials 1356 1356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pranoyk
approved these changes
Jan 2, 2024
sahil-lakhwani
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a package has deployment already, we should set the package status to none instead of pending. If we have a package that has source, we set the status to pending. If both source and deployment are empty, the package is marked as failure.
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: