Skip to content

Separated events permission in keda and executor linked roles #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Separated events permission in keda and executor linked roles #2885

merged 1 commit into from
Nov 30, 2023

Conversation

DadaGore
Copy link
Contributor

Description

Created separate permissions for events in keda and executor linked roles to remove delete permissions.

Which issue(s) this PR fixes:

This PR fixes issue - Remove event.delete permission #2884
Fixes #2884

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake sanketsudake merged commit 1fe1362 into fission:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

@sahil-lakhwani sahil-lakhwani Awaiting requested review from sahil-lakhwani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove event.delete permission
2 participants
@DadaGore @sanketsudake