Use concurrency in poolmanager as per old behaviour #2876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2876 +/- ##
=======================================
Coverage 43.55% 43.55%
=======================================
Files 218 218
Lines 22971 22979 +8
=======================================
+ Hits 10004 10008 +4
- Misses 11695 11698 +3
- Partials 1272 1273 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
pranoyk
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we made fixes for #1939 and #2452
As part of the above issues, we added more swift way to handle concurrency #2737
and reduce bursts in pod specialization when initial bulk calls are made to the function.
In the earlier approach, we used all the capacity of a single pod(actual + virtual) and then used to specialize further pods.
This causes failure of requests if specific pod specialization fails.
This PR changes the approach a bit and uses concurrency aggressively until a point it is available(to the limit). Once we exhausted concurrency we consider using the virtual capacity of the pods until specialization finishes.
Combining this and old approach will ensure we specialize pods as much as possible and then switch to virtual capacity up to request per pod limit.
Which issue(s) this PR fixes:
Fixes #1939
Testing
Checklist: