Remove deprecated mqtrigger with kind fission #2875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 43.56% 44.24% +0.67%
==========================================
Files 218 213 -5
Lines 22985 22465 -520
==========================================
- Hits 10014 9939 -75
+ Misses 11698 11260 -438
+ Partials 1273 1266 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
d110229 to
3872631
Compare
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
soharab-ic
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit f44174d.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes fission mqtrigger for kafka which implemented old approach.
https://fission.io/docs/usage/triggers/message-queue-trigger/kafka/
So effectively we are supporting only keda based mqtriggeres https://fission.io/docs/usage/triggers/message-queue-trigger-kind-keda/
This old connector has been lot of maintenance work, so we are removing it as it has been marked deprecated in last couple of releases.
Which issue(s) this PR fixes:
Fixes #
Testing
Checklist: