Skip to content

Add tests for preupgradchecks and spec/archive CLI #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

sanketsudake
Copy link
Member

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake requested a review from pranoyk November 16, 2023 15:21
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (e7d6381) 36.43% compared to head (5c747ce) 43.53%.

Files Patch % Lines
cmd/preupgradechecks/main.go 0.00% 9 Missing ⚠️
pkg/fission-cli/cmd/package/util/util.go 0.00% 5 Missing ⚠️
cmd/preupgradechecks/checks.go 33.33% 4 Missing ⚠️
pkg/fission-cli/cliwrapper/driver/dummy/dummy.go 0.00% 4 Missing ⚠️
pkg/fission-cli/cliwrapper/driver/cobra/cobra.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
+ Coverage   36.43%   43.53%   +7.09%     
==========================================
  Files         260      218      -42     
  Lines       25593    22971    -2622     
==========================================
+ Hits         9326    10001     +675     
+ Misses      15215    11697    -3518     
- Partials     1052     1273     +221     
Flag Coverage Δ
unittests 43.53% <33.33%> (+7.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake changed the title Add tests for preupgradchecks Add tests for preupgradchecks and spec/archive CLI Nov 17, 2023
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit d23ed57 into main Nov 17, 2023
@sanketsudake sanketsudake deleted the preupgrade-checks branch November 30, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant