Skip to content

Add CLI tests for mqtrigger/timetrigger #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Add CLI tests for mqtrigger/timetrigger #2872

merged 4 commits into from
Nov 13, 2023

Conversation

sanketsudake
Copy link
Member

Description

  • Add tests for mqtrigger and timetrigger
  • Cover more commands across fission CLI

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake changed the title Add tests for mqtrigger/timetrigger Add CLI tests for mqtrigger/timetrigger Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2872 (f0a6dc7) into main (2e4825d) will increase coverage by 12.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2872       +/-   ##
===========================================
+ Coverage   22.99%   35.23%   +12.24%     
===========================================
  Files          84      262      +178     
  Lines       10876    25721    +14845     
===========================================
+ Hits         2501     9064     +6563     
- Misses       8191    15649     +7458     
- Partials      184     1008      +824     
Flag Coverage Δ
unittests 35.23% <ø> (+12.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 237 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 57b537f into main Nov 13, 2023
@sanketsudake sanketsudake deleted the fn-test-cli branch November 30, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant