Skip to content

Add informers and internal go routines in manager #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 10, 2023
Merged

Add informers and internal go routines in manager #2870

merged 8 commits into from
Nov 10, 2023

Conversation

vardhaman-surana
Copy link
Contributor

@vardhaman-surana vardhaman-surana commented Nov 9, 2023 •
edited
Loading

Description

In continuation to the PR: #2869, this PR adds manager in more places.
This PR also adds one more function : AddInformers to manager, so that informers can also be managed by it.

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

sanketsudake
sanketsudake reviewed Nov 9, 2023
View reviewed changes
sanketsudake
sanketsudake reviewed Nov 9, 2023
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Merging #2870 (6fa44a5) into main (2a40b45) will decrease coverage by 0.05%.
The diff coverage is 14.73%.

@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
- Coverage   23.04%   23.00%   -0.05%     
==========================================
  Files          84       84              
  Lines       10834    10873      +39     
==========================================
+ Hits         2497     2501       +4     
- Misses       8154     8188      +34     
- Partials      183      184       +1
Flag Coverage Δ
unittests 23.00% <14.73%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kg/executor/executortype/newdeploy/newdeploymgr.go 22.33% <100.00%> (-0.24%) ⬇️
...executor/executortype/poolmgr/poolpodcontroller.go 29.72% <100.00%> (+0.98%) ⬆️
pkg/mqtrigger/mqtmanager.go 38.28% <0.00%> (-0.61%) ⬇️
pkg/router/router.go 0.00% <0.00%> (ø)
pkg/storagesvc/storagesvc.go 0.00% <0.00%> (ø)
pkg/mqtrigger/scalermanager.go 26.78% <0.00%> (-0.13%) ⬇️
pkg/utils/manager/manager.go 81.25% <0.00%> (-18.75%) ⬇️
pkg/router/httpTriggers.go 0.67% <0.00%> (-0.01%) ⬇️
pkg/executor/executortype/poolmgr/gpm.go 6.37% <0.00%> (-0.09%) ⬇️
pkg/storagesvc/archivePruner.go 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sanketsudake sanketsudake changed the title replaced more go routines with manager.Add Add informers and internal go routines in manager Nov 10, 2023
@sanketsudake sanketsudake merged commit 3fabf64 into fission:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vardhaman-surana @sanketsudake