Skip to content

Add interfaces for executor/fetcher/storagesvc clients #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add interfaces for executor/fetcher/storagesvc clients #2867

merged 1 commit into from
Nov 6, 2023

Conversation

sanketsudake
Copy link
Member

Description

  • Making all fission contained http clients internal and adding interfaces for them
  • This would help in testing services individually and test them with mocks

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Add interfaces for executor/fetcher/storagesvc clients
f62b178 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake requested a review from pranoyk November 5, 2023 04:59
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #2867 (f62b178) into main (88039ca) will increase coverage by 0.01%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
+ Coverage   22.86%   22.87%   +0.01%     
==========================================
  Files          83       83              
  Lines       10803    10801       -2     
==========================================
+ Hits         2470     2471       +1     
+ Misses       8150     8147       -3     
  Partials      183      183
Flag Coverage Δ
unittests 22.87% <58.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/router/functionHandler.go 10.55% <ø> (ø)
pkg/mqtrigger/scalermanager.go 26.91% <0.00%> (ø)
pkg/router/httpTriggers.go 0.67% <0.00%> (ø)
pkg/storagesvc/client/client.go 45.77% <87.50%> (ø)
pkg/router/router.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

pranoyk
pranoyk reviewed Nov 6, 2023
View reviewed changes
@sanketsudake sanketsudake merged commit 2713297 into main Nov 6, 2023
@sanketsudake sanketsudake deleted the client-interfaces branch November 30, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranoyk pranoyk pranoyk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @pranoyk