Skip to content

Add cause for all context timeouts #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2023
Merged

Add cause for all context timeouts #2862

merged 2 commits into from
Oct 29, 2023

Conversation

sanketsudake
Copy link
Member

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Add cause for all context timeouts
fc140f7 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #2862 (b2d1974) into main (2223081) will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   22.83%   22.87%   +0.03%     
==========================================
  Files          83       83              
  Lines       10803    10803              
==========================================
+ Hits         2467     2471       +4     
+ Misses       8152     8149       -3     
+ Partials      184      183       -1
Flag Coverage Δ
unittests 22.87% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/publisher/webhookPublisher.go 69.31% <100.00%> (ø)
pkg/tracker/tracker.go 89.65% <100.00%> (ø)
pkg/fission-cli/cmd/function/test.go 0.00% <0.00%> (ø)
pkg/router/functionHandler.go 10.55% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake requested a review from pranoyk October 27, 2023 12:10
pranoyk
pranoyk reviewed Oct 27, 2023
View reviewed changes
@sanketsudake
remove waitgroup
b2d1974 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 267f7fa into main Oct 29, 2023
@sanketsudake sanketsudake deleted the context-cause branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranoyk pranoyk pranoyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @pranoyk