Skip to content

Test for httptrigger and functions container/newdeploy #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2023
Merged

Test for httptrigger and functions container/newdeploy #2861

merged 3 commits into from
Oct 27, 2023

Conversation

sanketsudake
Copy link
Member

Description

Added more tests with envtest for httptrigger and container/newdeploy

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Test for httptrigger and functions
28135e9 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #2861 (400ee7a) into main (2eb2eba) will increase coverage by 0.02%.
The diff coverage is 22.66%.

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
+ Coverage   22.84%   22.87%   +0.02%     
==========================================
  Files          83       83              
  Lines       10806    10803       -3     
==========================================
+ Hits         2469     2471       +2     
+ Misses       8155     8149       -6     
- Partials      182      183       +1
Flag Coverage Δ
unittests 22.87% <22.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/executor/util/util.go 27.08% <100.00%> (-0.10%) ⬇️
pkg/executor/fscache/poolcache.go 77.77% <50.00%> (+0.80%) ⬆️
pkg/router/httpTriggers.go 0.67% <0.00%> (ø)
pkg/executor/executortype/poolmgr/gp_deployment.go 7.80% <0.00%> (+0.03%) ⬆️
pkg/executor/executortype/newdeploy/newdeploy.go 53.52% <14.28%> (ø)
pkg/executor/util/merge.go 43.28% <62.50%> (ø)
pkg/executor/executortype/poolmgr/gpm.go 6.46% <0.00%> (ø)
pkg/executor/executortype/poolmgr/gp.go 0.00% <0.00%> (ø)
pkg/fission-cli/cmd/function/test.go 0.00% <0.00%> (ø)
...kg/executor/executortype/newdeploy/newdeploymgr.go 22.56% <5.26%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake
Fixes with multierror
4236bc4 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 27, 2023
View reviewed changes
@sanketsudake
review changes
400ee7a 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake requested a review from pranoyk October 27, 2023 07:01
@sanketsudake sanketsudake merged commit 2223081 into main Oct 27, 2023
@sanketsudake sanketsudake deleted the httptrigger-fn-tests branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranoyk pranoyk pranoyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @pranoyk