Skip to content

Envtest based integration tests for Fission #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 26, 2023
Merged

Envtest based integration tests for Fission #2858

merged 17 commits into from
Oct 26, 2023

Conversation

sanketsudake
Copy link
Member

Description

  • Added test with envtest based framework
  • Added Fission CLI tests sample

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

pranoyk and others added 4 commits October 24, 2023 13:01
@pranoyk @sanketsudake
skeleton for envtest fission
aa2f32a
@sanketsudake
Refactor code and add CLI test
32d3c52 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
hack
6c79b8b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Update server test
9a5ce05 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
remove skip-ci for lint tests
c44b2df 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Pass client go storagesvc
3411692 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Add clientGen interface across code
bf05730 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Fix storagesvc test
43d53c8 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Fix cmd client
fff6a9b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
add retry in server test
d3f72bb 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Fix concurrenct access to pool deployment
025970c 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #2858 (6567e08) into main (fc97b76) will increase coverage by 1.89%.
Report is 2 commits behind head on main.
The diff coverage is 0.80%.

@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
+ Coverage   20.96%   22.85%   +1.89%     
==========================================
  Files          68       83      +15     
  Lines        7313    10806    +3493     
==========================================
+ Hits         1533     2470     +937     
- Misses       5668     8154    +2486     
- Partials      112      182      +70
Flag Coverage Δ
unittests 22.85% <0.80%> (+1.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/mqtrigger/mqtmanager.go 39.51% <0.00%> (ø)
pkg/storagesvc/archivePruner.go 0.00% <0.00%> (ø)
pkg/fission-cli/util/portforward.go 0.00% <0.00%> (ø)
pkg/utils/metrics/server.go 0.00% <0.00%> (ø)
pkg/executor/executortype/poolmgr/gp.go 0.00% <0.00%> (ø)
...xecutor/executortype/poolmgr/readyPodController.go 0.00% <0.00%> (ø)
pkg/storagesvc/storagesvc.go 0.00% <0.00%> (ø)
pkg/executor/executortype/poolmgr/gp_deployment.go 7.76% <0.00%> (ø)
...executor/executortype/poolmgr/poolpodcontroller.go 28.73% <0.00%> (ø)
pkg/executor/executortype/poolmgr/gpm.go 6.46% <0.00%> (ø)
... and 5 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake
Remove old executor test
9719375 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
get rid of ginkgo/gomega
d1c91f6 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
disable flaky test
c66c727 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
flaky test
4bc2b76 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake changed the title [WIP] Envtest based tests for Fission Envtest based tests for Fission Oct 25, 2023
@sanketsudake
revert ci change
1fd4c3d 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake requested a review from pranoyk October 25, 2023 15:36
@sanketsudake sanketsudake changed the title Envtest based tests for Fission Envtest based integration tests for Fission Oct 25, 2023
@sanketsudake sanketsudake merged commit 8a17d39 into main Oct 26, 2023
@sanketsudake sanketsudake deleted the envtest branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranoyk pranoyk pranoyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @pranoyk