Skip to content

Avoid duplicate role in release namespace for router #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

sanketsudake
Copy link
Member

Description

Avoid unnecessary role and rolebinding creation for router .
We are creating role and rolebinding in release namespace for router which is not required and causes installation issue when release namespace and default namespace is same.

Which issue(s) this PR fixes:

Fixes #2855

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 7137b39 into main Oct 18, 2023
@sanketsudake sanketsudake deleted the fix-router-rolebindings branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fission router creating duplicate role/rolebinding when release namespace is same as defaultNamespace
3 participants