Skip to content

added client generator inteface #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2023
Merged

added client generator inteface #2854

merged 2 commits into from
Oct 18, 2023

Conversation

vardhaman-surana
Copy link
Contributor

@vardhaman-surana vardhaman-surana commented Oct 18, 2023 •
edited
Loading

Description

  • the functions to start services were tightly coupled with ClientGenerator. This PR modifies those function to accept clientGen as an argument.
  • This PR adds a ClientGeneratorInterface so that ClientGenerator can be mocked if needed to write unit test cases for the function which requires ClientGenerator.

Which issue(s) this PR fixes:

Fixes # N/A

Testing

ran make check and make test-run locally.

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@vardhaman-surana
added client generator inteface
adb6ade 
---

Signed-off-by: Vardhaman Surana <vardhaman.surana@infracloud.io>
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #2854 (7f8d41d) into main (c6329ee) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   20.91%   20.94%   +0.03%     
==========================================
  Files          68       68              
  Lines        7326     7313      -13     
==========================================
  Hits         1532     1532              
+ Misses       5682     5669      -13     
  Partials      112      112
Flag Coverage Δ
unittests 20.94% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/router/router.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vardhaman-surana vardhaman-surana force-pushed the add-client-gen-interface branch 4 times, most recently from 2751df8 to aa1289b Compare October 18, 2023 10:56
sanketsudake
sanketsudake reviewed Oct 18, 2023
View reviewed changes
@vardhaman-surana
start router service asynchronously
7f8d41d 
---

Signed-off-by: Vardhaman Surana <vardhaman.surana@infracloud.io>
@vardhaman-surana vardhaman-surana force-pushed the add-client-gen-interface branch from aa1289b to 7f8d41d Compare October 18, 2023 10:59
@sanketsudake sanketsudake merged commit fc97b76 into fission:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vardhaman-surana @sanketsudake