Skip to content

Remove controller component from Fission #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

sanketsudake
Copy link
Member

Description

This PR removes controller from Fission repo as we no longer see direct use of it and prefer Kubernetes API call only instead of proxy calls.

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2850 (5f3f39b) into main (c09319c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
+ Coverage   20.76%   20.79%   +0.03%     
==========================================
  Files          68       68              
  Lines        7372     7361      -11     
==========================================
  Hits         1531     1531              
+ Misses       5727     5716      -11     
  Partials      114      114              
Flag Coverage Δ
unittests 20.79% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/fission-cli/cmd/package/util/util.go 5.02% <ø> (+0.29%) ⬆️
pkg/router/router.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake marked this pull request as ready for review October 17, 2023 02:23
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake sanketsudake merged commit 703d757 into main Oct 17, 2023
@sanketsudake sanketsudake deleted the remove-controller branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant