Skip to content

Update kubernetes libs to latest #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

Update kubernetes libs to latest #2834

merged 1 commit into from
Sep 23, 2023

Conversation

sanketsudake
Copy link
Member

Description

  • k8s.io/api v0.28.1
  • k8s.io/apiextensions-apiserver v0.28.1
  • k8s.io/apimachinery v0.28.1
  • k8s.io/client-go v0.28.1
  • k8s.io/metrics v0.28.1
  • sigs.k8s.io/controller-runtime v0.16.1
  • sigs.k8s.io/controller-tools v0.13.0

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@sanketsudake
Update kubernetes libs to latest
545896c 
- k8s.io/api v0.28.1
- k8s.io/apiextensions-apiserver v0.28.1
- k8s.io/apimachinery v0.28.1
- k8s.io/client-go v0.28.1
- k8s.io/metrics v0.28.1
- sigs.k8s.io/controller-runtime v0.16.1
- sigs.k8s.io/controller-tools v0.13.0

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sahil-lakhwani
Copy link
Contributor

A nit pick is to use

if err := someFunc(); err != nil {
 // doSomething
}

instead of

err := someFunc()
if err != nil {
 // doSomething
}

wherever possible

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2834 (545896c) into main (9974933) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   20.86%   20.79%   -0.07%     
==========================================
  Files          68       68              
  Lines        7344     7367      +23     
==========================================
  Hits         1532     1532              
- Misses       5698     5721      +23     
  Partials      114      114
Flag Coverage Δ
unittests 20.79% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/mqtrigger/mqtmanager.go 39.51% <0.00%> (-1.32%) ⬇️
pkg/mqtrigger/scalermanager.go 25.60% <0.00%> (-0.18%) ⬇️
pkg/router/httpTriggers.go 0.69% <0.00%> (-0.04%) ⬇️
pkg/router/router.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake
Copy link
Member Author

A nit pick is to use

if err := someFunc(); err != nil {
 // doSomething
}

instead of

err := someFunc()
if err != nil {
 // doSomething
}

wherever possible

Will target this in followup PRs across codebase.

@sanketsudake sanketsudake merged commit 3bcda55 into main Sep 23, 2023
@sanketsudake sanketsudake deleted the k8s-libs-update branch November 2, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil-lakhwani sahil-lakhwani Awaiting requested review from sahil-lakhwani

@neha-Gupta1 neha-Gupta1 Awaiting requested review from neha-Gupta1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketsudake @sahil-lakhwani