Skip to content

Ability to retain specialised pods for poolmanager functions #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 27, 2023
Merged

Ability to retain specialised pods for poolmanager functions #2830

merged 10 commits into from
Sep 27, 2023

Conversation

sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented Aug 29, 2023 •
edited by pranoyk
Loading

Description

  • added retainPods flag to take in the number of specialized pods to retain
  • add retainPods in both the create function and update function command
  • modify crd keys to be typed instead of string
  • keep track of function generation in case of update function operation
  • add delete handler function to make sure specialized pods are deleted in case function is deleted

Which issue(s) this PR fixes:

Fixes #2840

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #2830 (e8ac8f1) into main (657aee7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2830      +/-   ##
==========================================
- Coverage   20.78%   20.78%   -0.01%     
==========================================
  Files          68       68              
  Lines        7367     7372       +5     
==========================================
+ Hits         1531     1532       +1     
- Misses       5722     5726       +4     
  Partials      114      114
Flag Coverage Δ
unittests 20.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/router/functionHandler.go 10.55% <0.00%> (ø)
pkg/fission-cli/cmd/function/command.go 0.00% <0.00%> (ø)
pkg/fission-cli/cmd/function/create.go 27.25% <0.00%> (-0.12%) ⬇️
pkg/fission-cli/cmd/function/update.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@airhorns
Copy link

Hey folks it'd be really great to get this in and released! A+ feature for avoiding cold boots!

@sanketsudake
Copy link
Member Author

sanketsudake commented Sep 23, 2023 •
edited by pranoyk
Loading

We have few tasks pending in the PR. We should close out soon this week.

Outstanding issue:

  • In case of function upgrade retain pods is not strictly followed, we need to fix it. As cache maintains metadata per function version.
  • Pods retained after function deletion.

sanketsudake and others added 2 commits September 24, 2023 11:35
@sanketsudake
Add retain pods parameter
bd97c16 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@pranoyk @sanketsudake
set retainpod flag in create and update function
1853e62
sanketsudake and others added 5 commits September 24, 2023 12:49
@sanketsudake
goreleaser command fix
bf1e001 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Change level1
2d9cf5b 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
add types for cache
e834a1c 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@sanketsudake
Consider latest version for svcretain
298fd66 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@pranoyk
handle delete function
ead076f 
Signed-off-by: Pranoy Kundu <pranoy1998k@gmail.com>
sanketsudake
sanketsudake commented Sep 26, 2023
View reviewed changes
@pranoyk
update log level and fix function names
33ffd3c 
Signed-off-by: Pranoy Kundu <pranoy1998k@gmail.com>
@pranoyk
add test cases for pool cache
9baef20 
Signed-off-by: Pranoy Kundu <pranoy1998k@gmail.com>
@pranoyk
refine test cases
e8ac8f1 
Signed-off-by: Pranoy Kundu <pranoy1998k@gmail.com>
@sanketsudake sanketsudake marked this pull request as ready for review September 27, 2023 07:24
@sanketsudake sanketsudake changed the title Add retain pods parameter Ability to retain specialised pods for poolmanager functions Sep 27, 2023
@sanketsudake sanketsudake merged commit 56b49dc into main Sep 27, 2023
@sanketsudake sanketsudake deleted the poolmgr-pods-retain branch November 2, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranoyk pranoyk Awaiting requested review from pranoyk

@sahil-lakhwani sahil-lakhwani Awaiting requested review from sahil-lakhwani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to retain specialized pods
3 participants
@sanketsudake @airhorns @pranoyk