Skip to content

fix missing namespace environment variables for various services #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

fix missing namespace environment variables for various services #2828

merged 1 commit into from
Sep 23, 2023

Conversation

antdking
Copy link
Contributor

@antdking antdking commented Aug 16, 2023 •
edited
Loading

Description

Ensure all Namespace related environment variables are passed to the Fission Deployments.

As part of starting the services, CRDs are checked, which requires the correct FISSION_DEFAULT_NAMESPACE be set.
Move all Namespace related environment variables to the 'fission-resource-namespace' macro to ensure all services know the relavant namespaces.

Which issue(s) this PR fixes:

Fixes #2732

Testing

Tested running in a cluster that doesn't use the default namespace; ie:

defaultNamespace: tenant-user-funcs

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@antdking antdking force-pushed the fix-chart-namespace-environment-variables branch from 2f9f0ec to f209dae Compare August 16, 2023 11:51
fix missing namespace environment variables for various services
f209dae 
the FISSION_..._NAMESPACE environment variables are used by all services during init
to check if the CRDs are loaded.

Move them to the 'fission-resource-namespace' macro to ensure all services know the relavant namespaces.

Signed-off-by: Anthony King <anthony@datapane.com>
@sanketsudake sanketsudake self-requested a review August 16, 2023 13:13
@sanketsudake
Copy link
Member

Thanks @antdking for the PR 🎉

@sanketsudake sanketsudake merged commit 44922bc into fission:main Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake Awaiting requested review from sanketsudake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.18.0, custom namespace, Waiting for CRDs to be installed
2 participants
@antdking @sanketsudake