Skip to content

make binary small #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

make binary small #115

merged 1 commit into from
Apr 11, 2024

Conversation

kindy
Copy link
Contributor

@kindy kindy commented Apr 10, 2024

I like this project.

It seems that the binary is quite large, so I make some tests to see if we can reduce its size.

Here are the results:

  31M vsh                    go build -o vsh
  23M vsh_min                go build -trimpath -ldflags "-s -w" -o vsh_min
 9.7M vsh_notokenhelper      go build -tags 'notokenhelper' -o vsh_notokenhelper
 6.8M vsh_notokenhelper_min  go build -tags 'notokenhelper' -trimpath -ldflags "-s -w" -o vsh_notokenhelper_min

For users who do not require or use the vault token helper, they can install vsh as follows:

go install -tags 'notokenhelper' github.com/fishi0x01/vsh@latest

@fishi0x01
Copy link
Owner

Great idea! Thank you ❤️

I will create a follow-up MR to include these binaries in the build process

@fishi0x01
Copy link
Owner

Do you mind signing your commit?

@kindy kindy force-pushed the make-binary-small branch from 537afcb to 725acb1 Compare April 10, 2024 13:20
@kindy
Copy link
Contributor Author

kindy commented Apr 10, 2024

Do you mind signing your commit?

@fishi0x01 signed

@fishi0x01 fishi0x01 merged commit 14c7da7 into fishi0x01:master Apr 11, 2024
@fishi0x01 fishi0x01 mentioned this pull request Apr 11, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishi0x01 fishi0x01 fishi0x01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kindy @fishi0x01