Skip to content

Fix no-op #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2021
Merged

Fix no-op #85

merged 1 commit into from
Feb 21, 2021

Conversation

fishi0x01
Copy link
Owner

Currently, return on blank line shows an error in interactive mode:

http://localhost:8888 />                                                                                                                                                                                   
invalid syntax                                                                                                                                                                                             
http://localhost:8888 />

This PR fixes behavior to previous to allow enter on empty line:

http://localhost:8888 />                                                                                                                                                                                                                                                                                                                                                                          
http://localhost:8888 />

@fishi0x01 fishi0x01 added the bug Something isn't working label Feb 21, 2021
@fishi0x01 fishi0x01 self-assigned this Feb 21, 2021
mattlqx
mattlqx approved these changes Feb 21, 2021
View reviewed changes
Copy link
Collaborator

@mattlqx mattlqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks.

@fishi0x01 fishi0x01 merged commit 37192ef into master Feb 21, 2021
@fishi0x01 fishi0x01 deleted the fix-no-op branch February 21, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlqx mattlqx mattlqx approved these changes

Assignees

@fishi0x01 fishi0x01

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishi0x01 @mattlqx