feat(handler): migrate to handler #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2022
27a808a to
e10e9fc
Compare
BREAKING CHANGE: Migrate the LSP buffer request from manual to using `vim.lsp.buf.rename(...)` to make the request and a custom LSP response handler to manage the custom response processing (eg setting the qf list) and the original Neovim rename handler to apply the requested changes. This implies removing several existing function, doing some cleanup of tests and updating the documentation. Fixes: GH-117, GH-121 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
e10e9fc to
cf04479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BREAKING CHANGE: Migrate the LSP buffer request from manual to using
vim.lsp.buf.rename(...)to make the request and a custom LSP response handler to manage the custom response processing (eg setting the qf list) and the original Neovim rename handler to apply the requested changes.This implies removing several existing function, doing some cleanup of tests and updating the documentation.
Fixes: GH-117, fixes: GH-121
Proposed changes
renamer._setup(...)to change the default rename handler to the custom onelua/tests/renamer_rename_handler_spec.lua)Test plan
Existing tests are updated to match the new functionality and a new spec is added to test the custom handler.