Skip to content

Conversation

filipdutescu
Copy link
Owner

Motivation

This PR adds two new changes, related to GH-84:


BREAKING CHANGE: Add a new field, handler, representing a function to be called after successful renames, with the LSP textDocument/rename raw response.

Closes: GH-84


BREAKING CHANGE: TODO integrate nvim-notify

Proposed changes

  • add handler field to be called with the LSP raw response on successful renames
  • update docs

Test plan

Existing tests are updated to validate the new functionalities and new test cases are added for each new behaviour.

@filipdutescu filipdutescu added the help wanted Extra attention is needed label Nov 18, 2021
@filipdutescu filipdutescu added this to the 3.0.0 milestone Nov 18, 2021
@filipdutescu filipdutescu self-assigned this Nov 18, 2021
@github-actions github-actions bot added docs Improvements or additions to documentation test feature New feature or request labels Nov 18, 2021
@filipdutescu filipdutescu force-pushed the feature/submit_custom_handler_support branch from 220a535 to c82e225 Compare November 18, 2021 21:14
@filipdutescu filipdutescu marked this pull request as draft November 18, 2021 21:14
@filipdutescu filipdutescu force-pushed the feature/submit_custom_handler_support branch from c82e225 to 09030b3 Compare November 18, 2021 21:39
BREAKING CHANGE: Add a new field, `handler`, representing a function
to be called after successful renames, with the LSP
`textDocument/rename` raw response.

Closes: GH-84
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
@filipdutescu filipdutescu marked this pull request as ready for review November 18, 2021 21:59
@filipdutescu filipdutescu merged commit 09030b3 into develop Nov 18, 2021
@filipdutescu filipdutescu deleted the feature/submit_custom_handler_support branch November 18, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feature New feature or request help wanted Extra attention is needed test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a handler for textDocument/rename
1 participant