Skip to content

Conversation

filipdutescu
Copy link
Owner

Motivation

Remove unnecessary modification of first row, in utils.set_qf_list(), in order to properly populate the list.

Closes: GH-79

Proposed changes

  • remove row reassigning for the first row of a file

Test plan

Existing test are update to validate the new functionality.

@filipdutescu filipdutescu added this to the v2.0.0 milestone Nov 13, 2021
@filipdutescu filipdutescu self-assigned this Nov 13, 2021
@filipdutescu filipdutescu force-pushed the fix/first_row_inqf_list branch from 886c61b to 2f9e66b Compare November 13, 2021 09:19
Remove unnecessary modification of first row, in `utils.set_qf_list()`,
in order to properly populate the list.

Closes: GH-79
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
@filipdutescu filipdutescu merged commit 2f9e66b into develop Nov 13, 2021
@filipdutescu filipdutescu deleted the fix/first_row_inqf_list branch November 13, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] If the first row of a file is changed by rename, quickfix list is not properly set.
1 participant