fix!: fallback to LSP rename if popup cannot be drawn #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c6fed5 to
0f8fd8f
Compare
BREAKING CHANGE: Validate if the window height and width allow for the popup to be drawn, otherwise fallback to `vim.lsp.buf.rename()` and log an error. Closes: GH-12 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BREAKING CHANGE: Validate if the window height and width allow for the popup to be drawn, otherwise fallback to
vim.lsp.buf.rename()and log an error.Closes: GH-12
Proposed changes
rename()to fallback tovim.lsp.buf.rename()if there is no space to draw the popupTest plan
Existing tests are updated to cover the new functionality and new test cases are also added in
lua/tests/renamer_rename_spec.lua.