feat(api): implement miner creation deposit requirement #13308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
0x5459
commented
Sep 4, 2025
|
See: #13310 |
PR title now matches the required format.
ZenGround0
approved these changes
Sep 4, 2025
| @@ -477,7 +476,7 @@ func (g *Garbager) createMiner(ctx context.Context) *lapi.MsgLookup { | |||
| createStorageMinerMsg := &types.Message{ | |||
| To: power.Address, | |||
| From: worker, | |||
| Value: big.Zero(), | |||
| Value: types.FromFil(1), | |||
There was a problem hiding this comment.
Calculating deposit from api is probably more stable so there's less chance of this flaking. API is at g.node.
There was a problem hiding this comment.
Tracking issue to do this in a followup: #13312 . I'll resolve this comment.
56ef4b7
into
filecoin-project:tippy-actors-bundle-nv27
91 checks passed
This was referenced Sep 4, 2025
Closed
BigLep
added a commit
that referenced
this pull request
Sep 4, 2025
* chore: build: Update actor bundle to v17.0.0-dev1 * feat(api): implement miner creation deposit requirement (#13308) * feat(api): add `StateMinerCreationDeposit` API method for FIP-0077 * feat(miner): implement miner creation deposit calculation for FIP-0077 * feat(tests): add migration tests for miner creation deposit across NV26 and NV27 upgrades * chore(tests): remove multisig test functions * Update gen and docsgen-cli --------- Co-authored-by: TippyFlits <james.bluett@protocol.ai> Co-authored-by: 0x5459 <0x5459@protonmail.com> Co-authored-by: Steve Loeppky <biglep@filoz.org>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#13287
Proposed Changes
StateMinerCreationDepositAPI for deposit calculationAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that: