-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: build: Update actor bundle to v17.0.0-dev1 #13304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Filecoin actor bundle from v16.0.1 to v17.0.0-dev1 for all network configurations, including new manifest CIDs and actor CIDs for all built-in actors across all supported networks.
- Updates BundleGitTag from "v16.0.1" to "v17.0.0-dev1" for version 17 across all networks
- Updates ManifestCid for each network to correspond with the new bundle version
- Updates all individual actor CIDs (account, cron, datacap, eam, ethaccount, evm, init, multisig, paymentchannel, reward, storagemarket, storageminer, storagepower, system, verifiedregistry) for each network
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Here is the @claude analysis of the CI failures: Analysis Summary PR #13304 is failing CI checks because the actor bundle update from v16.0.1 to v17.0.0-dev1 introduces new miner creation deposit requirements that the existing test configurations don't satisfy. Root Cause The failing tests all show the same error: This occurs during genesis miner creation for integration tests at ~/lotus/chain/gen/genesis/miners.go:179. Key Issues
Connection to FIP-0077 While not explicitly referenced in the current lotus codebase, this deposit requirement likely implements the economic friction mechanism described in FIP-0077, which introduces mandatory deposits for miner creation to Required Fix Update test configurations in files like:
To set PowerBalance to at least types.NewInt(5937181320) or higher to satisfy the new miner creation deposit requirement. This is a straightforward configuration update that should resolve all the systematic test failures once implemented. The good news is that it looks to only be FIP-0077 related failures, which is what we're wanting to see. This will get worked on as part of #13287, with the cutoff of 2025-09-04T12:00:00Z per #fil-implementers slack discussion. |
@BigLep follow-up here is to write a basic integration test in migration_test.go that straddles the NV boundary and checks that methods are gone and some other basic probes. It also might be the most logical place to put a miner creation fee test too -- one before and one after upgrade to show it not needing, and then needing a fee of appropriate size. DDO tests can go in direct_data_onboard_test.go or direct_data_onboard_verified_test.go, just extending what we have there with some fevm-copypasta code to get a contract in. |
Makes sense, I assume that can come the 2025-09-04:12:00Z cutoff for getting this PR green so @TippyFlitsUK can do the Lotus 1.34.0 RC?
Am I right to assume that comment is relevant for #13286 ? if so, I'll copy it there. Or is FIP-0109's inclusion in the 17.0.0-dev1 actor bundle causing CI failures in this PR as well? |
#13286 is fine as is, not blocking this PR and shouldn't result in breakage. |
* feat(api): add `StateMinerCreationDeposit` API method for FIP-0077 * feat(miner): implement miner creation deposit calculation for FIP-0077 * feat(tests): add migration tests for miner creation deposit across NV26 and NV27 upgrades * chore(tests): remove multisig test functions
@TippyFlitsUK : I'll work on resolving conflicts now (unless you're already on it). |
Proposed Changes
Update actor bundle to v17.0.0-dev1
Checklist
Before you mark the PR ready for review, please make sure that: