Skip to content

Conversation

TippyFlitsUK
Copy link
Contributor

@TippyFlitsUK TippyFlitsUK commented Sep 3, 2025

Proposed Changes

Update actor bundle to v17.0.0-dev1

Checklist

Before you mark the PR ready for review, please make sure that:

@Copilot Copilot AI review requested due to automatic review settings September 3, 2025 20:43
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 3, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Filecoin actor bundle from v16.0.1 to v17.0.0-dev1 for all network configurations, including new manifest CIDs and actor CIDs for all built-in actors across all supported networks.

  • Updates BundleGitTag from "v16.0.1" to "v17.0.0-dev1" for version 17 across all networks
  • Updates ManifestCid for each network to correspond with the new bundle version
  • Updates all individual actor CIDs (account, cron, datacap, eam, ethaccount, evm, init, multisig, paymentchannel, reward, storagemarket, storageminer, storagepower, system, verifiedregistry) for each network

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TippyFlitsUK TippyFlitsUK added the skip/changelog This change does not require CHANGELOG.md update label Sep 3, 2025
@TippyFlitsUK TippyFlitsUK requested a review from BigLep September 3, 2025 20:59
@github-project-automation github-project-automation bot moved this to 🐱 Todo in nv27 Track Board Sep 3, 2025
@BigLep BigLep moved this from 🐱 Todo to 🔎 Awaiting Review in nv27 Track Board Sep 3, 2025
@BigLep
Copy link
Member

BigLep commented Sep 3, 2025

Here is the @claude analysis of the CI failures:


Analysis Summary

PR #13304 is failing CI checks because the actor bundle update from v16.0.1 to v17.0.0-dev1 introduces new miner creation deposit requirements that the existing test configurations don't satisfy.

Root Cause

The failing tests all show the same error:
not enough balance to lock for create miner deposit: sent balance 0 < deposit 5937181320 (19)

This occurs during genesis miner creation for integration tests at ~/lotus/chain/gen/genesis/miners.go:179.

Key Issues

  1. Actor Bundle Change: The v17.0.0-dev1 bundle now requires a ~5.937 nanoFIL deposit for miner creation
  2. Test Configuration: All test setups use PowerBalance: big.Zero(), providing insufficient funds
  3. Systematic Failure: This same error appears across all failing test types (itest-api, itest-eth_api, itest-fevm, etc.)

Connection to FIP-0077

While not explicitly referenced in the current lotus codebase, this deposit requirement likely implements the economic friction mechanism described in FIP-0077, which introduces mandatory deposits for miner creation to
prevent spam attacks.

Required Fix

Update test configurations in files like:

  • ~/lotus/storage/sealer/mock/util.go:47
  • ~/lotus/cmd/lotus-seed/main.go:208
  • ~/lotus/cmd/lotus-seed/seed/seed.go:116

To set PowerBalance to at least types.NewInt(5937181320) or higher to satisfy the new miner creation deposit requirement.

This is a straightforward configuration update that should resolve all the systematic test failures once implemented.


The good news is that it looks to only be FIP-0077 related failures, which is what we're wanting to see. This will get worked on as part of #13287, with the cutoff of 2025-09-04T12:00:00Z per #fil-implementers slack discussion.

@BigLep BigLep mentioned this pull request Sep 3, 2025
2 tasks
@rvagg
Copy link
Member

rvagg commented Sep 4, 2025

@BigLep follow-up here is to write a basic integration test in migration_test.go that straddles the NV boundary and checks that methods are gone and some other basic probes. It also might be the most logical place to put a miner creation fee test too -- one before and one after upgrade to show it not needing, and then needing a fee of appropriate size. DDO tests can go in direct_data_onboard_test.go or direct_data_onboard_verified_test.go, just extending what we have there with some fevm-copypasta code to get a contract in.

@BigLep
Copy link
Member

BigLep commented Sep 4, 2025

@rvagg:

follow-up here is to write a basic integration test in migration_test.go that straddles the NV boundary and checks that methods are gone and some other basic probes. It also might be the most logical place to put a miner creation fee test too -- one before and one after upgrade to show it not needing, and then needing a fee of appropriate size.

Makes sense, I assume that can come the 2025-09-04:12:00Z cutoff for getting this PR green so @TippyFlitsUK can do the Lotus 1.34.0 RC?

DDO tests can go in direct_data_onboard_test.go or direct_data_onboard_verified_test.go, just extending what we have there with some fevm-copypasta code to get a contract in.

Am I right to assume that comment is relevant for #13286 ? if so, I'll copy it there. Or is FIP-0109's inclusion in the 17.0.0-dev1 actor bundle causing CI failures in this PR as well?

@rvagg
Copy link
Member

rvagg commented Sep 4, 2025

#13286 is fine as is, not blocking this PR and shouldn't result in breakage.

* feat(api): add `StateMinerCreationDeposit` API method for FIP-0077

* feat(miner): implement miner creation deposit calculation for FIP-0077

* feat(tests): add migration tests for miner creation deposit across NV26 and NV27 upgrades

* chore(tests): remove multisig test functions
This was referenced Sep 4, 2025
@BigLep
Copy link
Member

BigLep commented Sep 4, 2025

@TippyFlitsUK : I'll work on resolving conflicts now (unless you're already on it).

@BigLep BigLep enabled auto-merge (squash) September 4, 2025 18:04
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Sep 4, 2025
@BigLep BigLep merged commit 67f63f4 into master Sep 4, 2025
97 of 98 checks passed
@BigLep BigLep deleted the tippy-actors-bundle-nv27 branch September 4, 2025 18:06
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 4, 2025
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to 🎉 Done in nv27 Track Board Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: 🎉 Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

4 participants