Skip to content

fix: properly handle all RPC API retry errors #13279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

fix: properly handle all RPC API retry errors #13279

merged 2 commits into from
Aug 26, 2025

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 25, 2025

Ref: filecoin-project/curio#605

Discovered in Curio but we have the same problem.

Doing some dedupe while I'm at it.

@rvagg rvagg requested review from wjmelements and Copilot August 25, 2025 05:46
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Aug 25, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Aug 25, 2025
Copilot
Copilot AI reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

wjmelements
wjmelements reviewed Aug 25, 2025
View reviewed changes
wjmelements
wjmelements reviewed Aug 25, 2025
View reviewed changes
wjmelements
wjmelements reviewed Aug 25, 2025
View reviewed changes
@BigLep BigLep moved this from 📌 Triage to ⌨️ In Progress in FilOz Aug 26, 2025
@github-project-automation github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Aug 26, 2025
@rvagg rvagg merged commit 49191d7 into master Aug 26, 2025
98 checks passed
@rvagg rvagg deleted the rvagg/handle-retry-err branch August 26, 2025 05:59
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Aug 26, 2025
@BigLep BigLep mentioned this pull request Sep 4, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@wjmelements wjmelements wjmelements approved these changes

Assignees

@rvagg rvagg

Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
FilOz
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @wjmelements