Skip to content

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 13, 2025

Ref: #13249

@rjan90 @TippyFlitsUK any idea of what might break if we rename these files in documentation/en?

@Copilot Copilot AI review requested due to automatic review settings August 13, 2025 04:58
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Aug 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Lotus API documentation and code to clarify API versioning by marking the v0 API as "deprecated", the v1 API as "stable", and the v2 API as "experimental". The changes primarily involve renaming output files to reflect these stability levels and updating comments throughout the codebase.

  • Refactors documentation generation to use descriptive file names indicating API stability
  • Updates API interface documentation to clarify version stability and recommendations
  • Reorganizes code structure with constants for better maintainability

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gen/docs/main.go Refactored to use constants for file paths with stability indicators and reorganized generation functions
documentation/en/api-methods-v2-experimental.md Updated experimental API warning message for clarity
api/v2api/full.go Enhanced documentation to clarify experimental status and recommend v1 API
api/v0api/gateway.go Updated comments to mark v0 as deprecated and v1 as stable
api/v0api/full.go Added deprecation warning and recommendation to use v1 API
api/api_gateway.go Added comprehensive documentation for Gateway API purpose and stability
api/api_full.go Updated comments to indicate v1 API stability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rvagg rvagg force-pushed the rvagg/deprecate-stabilise branch from 1b525b8 to 4ddcbe6 Compare August 13, 2025 04:59
Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think there anything will break, at least from the https://lotus.filecoin.io perspective.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Aug 13, 2025
@rvagg rvagg merged commit 160716e into master Aug 14, 2025
176 of 177 checks passed
@rvagg rvagg deleted the rvagg/deprecate-stabilise branch August 14, 2025 01:22
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants