chore: stop using F3Backend directly in Eth modules #13127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to decouple Eth modules from directly depending on the legacy F3Backend by replacing it with a certificate provider abstraction.
- Replace F3Backend with F3CertificateProvider in the Eth module constructor and types.
- Update the tipset resolver to call the new method on the certificate provider.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| node/modules/eth.go | Updated the dependency type from lf3.F3Backend to full.F3CertificateProvider. |
| node/impl/eth/tipsetresolver.go | Adjusted the tipset resolver to use the new provider interface and method. |
Comments suppressed due to low confidence (2)
node/impl/eth/tipsetresolver.go:42
- The error check still references f3.ErrF3NotRunning even though the lf3 package has been removed. Update this reference to use the appropriate error constant from the new certificate provider package.
if errors.Is(err, f3.ErrF3NotRunning) || errors.Is(err, api.ErrF3NotReady) {
node/impl/eth/tipsetresolver.go:22
- [nitpick] Consider aligning the F3CertificateProvider interface defined locally with the one imported in node/modules/eth.go (from the full package) to ensure consistent type usage across modules.
type F3CertificateProvider interface {
masih
approved these changes
May 13, 2025
masih
added a commit
that referenced
this pull request
May 13, 2025
Disable F3 module when lotus is run with `--lite` commend since in that mode the daemon is simply a reverse proxy of a full node. Stop using F3Backend directly in Eth modules (#13127)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #13123 to explore how we can further decouple F3.