Skip to content

Conversation

masih
Copy link
Member

@masih masih commented May 11, 2025

Disable F3 module when lotus is run with --lite commend since in that mode the daemon is simply a reverse proxy of a full node.

Fixes #13122

Disable F3 module when lotus is run with `--lite` commend since in that
mode the daemon is simply a reverse proxy of a full node.
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz May 11, 2025
@github-project-automation github-project-automation bot moved this to Todo in F3 May 11, 2025
@masih masih marked this pull request as ready for review May 11, 2025 16:15
@masih masih requested a review from rvagg May 11, 2025 16:16
@masih
Copy link
Member Author

masih commented May 12, 2025

@rvagg Apologies re commit noise. This PR is now ready for review. It

  • Obeys "f3 disablement" knobs across both lite mode and full mode.
  • Never instantiates the F3 participation in lite mode.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with #13127 being my experiment in taking this further

@github-project-automation github-project-automation bot moved this from Todo to In review in F3 May 13, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz May 13, 2025
@masih masih enabled auto-merge (squash) May 13, 2025 14:45
@masih masih merged commit 42626fd into master May 13, 2025
94 of 96 checks passed
@masih masih deleted the masih/f3-be-gone-in-gateway branch May 13, 2025 14:48
@github-project-automation github-project-automation bot moved this from In review to Done in F3 May 13, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz May 13, 2025
rvagg added a commit that referenced this pull request May 30, 2025
Fixes a problem introduced, but overlooked in
#13123
which meant that F3 was never wired into the v2 TipSetProvider. Integration
tests failed but we ignored it because we had a common flaky that was related
so didn't take notice of it.
rvagg added a commit that referenced this pull request May 30, 2025
Fixes a problem introduced, but overlooked in
#13123
which meant that F3 was never wired into the v2 TipSetProvider. Integration
tests failed but we ignored it because we had a common flaky that was related
so didn't take notice of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Lite note shouldn't participate in F3
2 participants