-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: disable F3 participation via gateway #13123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable F3 module when lotus is run with `--lite` commend since in that mode the daemon is simply a reverse proxy of a full node.
@rvagg Apologies re commit noise. This PR is now ready for review. It
|
rvagg
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with #13127 being my experiment in taking this further
rvagg
added a commit
that referenced
this pull request
May 30, 2025
Fixes a problem introduced, but overlooked in #13123 which meant that F3 was never wired into the v2 TipSetProvider. Integration tests failed but we ignored it because we had a common flaky that was related so didn't take notice of it.
rvagg
added a commit
that referenced
this pull request
May 30, 2025
Fixes a problem introduced, but overlooked in #13123 which meant that F3 was never wired into the v2 TipSetProvider. Integration tests failed but we ignored it because we had a common flaky that was related so didn't take notice of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable F3 module when lotus is run with
--lite
commend since in that mode the daemon is simply a reverse proxy of a full node.Fixes #13122