fix(f3): properly wire up eth v2 APIs for f3 #13149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem introduced, but overlooked in #13123 which meant that F3 was never wired into the v2 TipSetProvider. Integration tests failed but we ignored it because we had a common flaky that was related so didn't take notice of it.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where F3 was not properly wired into the v2 TipSetProvider, ensuring that the full F3 functionalities are available via the expanded API.
- Updated the tipset resolver parameters to use F3ModuleAPI instead of F3CertificateProvider.
- Extended the F3 API implementation with additional methods and ensured proper dependency injection via the builder.
- Updated the CHANGELOG to reflect the bug fix.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| node/modules/eth.go | Changed F3 type for tipset resolver to the expanded F3ModuleAPI. |
| node/impl/full/f3.go | Expanded the F3 interface to include additional API methods. |
| node/builder_chain.go | Updated dependency injection to wire F3ModuleAPI to its implementation. |
| CHANGELOG.md | Documented the bug fix and API updates in F3 integration. |
Comments suppressed due to low confidence (1)
node/impl/full/f3.go:27
- Ensure integration tests cover the newly added F3ModuleAPI methods to verify correct behavior, especially for ticket renewal and participation functionality.
F3GetOrRenewParticipationTicket(ctx context.Context, minerID address.Address, previous api.F3ParticipationTicket, instances uint64) (api.F3ParticipationTicket, error)
rjan90
approved these changes
May 30, 2025
masih
reviewed
Jun 2, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem introduced, but overlooked in
#13123 which meant that F3 was never wired into the v2 TipSetProvider. Integration tests failed but we ignored it because we had a common flaky that was related so didn't take notice of it.