feat(gateway): add CORS headers if --cors is provided #13145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows remote access from a browser sandbox if exposed Closes: #6402
There was a problem hiding this comment.
Pull Request Overview
Adds optional CORS header support to the gateway when the --cors flag is provided.
- Introduce
enableCORSoption in handler configuration and aWithCORSfunctional option - Wrap the main HTTP handler with a new
CORSHandlerwhen enabled - Expose a
--corsCLI flag inlotus-gatewayto toggle CORS support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gateway/handler.go | Added enableCORS option, CORSHandler type and wrapper; conditionally wrap handler |
| cmd/lotus-gateway/main.go | Introduce --cors flag and pass its value into WithCORS |
Comments suppressed due to low confidence (1)
gateway/handler.go:318
- There are no tests covering the new CORSHandler; consider adding unit tests to verify that CORS headers are correctly set and that preflight (OPTIONS) requests are handled.
func (h *CORSHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rjan90
approved these changes
May 28, 2025
|
We've got some failing tests |
At least the eth_api_f3 has been consistently failing for some time now: #13116. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows remote access from a browser sandbox if exposed.
I needed this for some browser dev work to talk to my local node, and I have it running now and it's 👌.
Closes: #6402