Skip to content

Conversation

masih
Copy link
Member

@masih masih commented Apr 24, 2025

In Lotus v2 APIs, in an event where F3 finalized tipset is too far behind EC, > 900 epochs return EC finalized tipset.

Part of: #13062

In Lotus v2 APIs, in an event where F3 finalized tipset is too far
behind EC, > 900 epochs return EC finalized tipset.

Part of: #13062
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 24, 2025
@masih masih requested a review from Kubuxu April 24, 2025 16:01
@masih masih self-assigned this Apr 24, 2025
@BigLep BigLep moved this to In review in F3 Apr 24, 2025
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually seems right/good to me and good to see a test. Will leave to someone else who commits code to the repo to approve.

Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels weird that this code is so duplicated
I'm cautious about needing finality resolution in more places. Once the third duplicate appears, let's refactor it out.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Apr 25, 2025
@masih
Copy link
Member Author

masih commented Apr 25, 2025

let's refactor it out.

Yes. A lot of refactoring needed.

@masih masih merged commit 6b832d6 into master Apr 25, 2025
94 checks passed
@masih masih deleted the masih/fil-v2-api-finalized-too-old-ec branch April 25, 2025 12:05
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 25, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants