fix build failure on Windows #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error was: .\common.go:75: cannot use syscall.Stdout (type syscall.Handle) as type int in argument to terminal.IsTerminal found solution here: golang/go#12978 (comment) tested both terminal and non terminal :) $ ./kt consume -pretty -topic WordsWithCountsTopic { "partition": 0, "offset": 0, "key": "", "value": "1" } $ ./kt consume -pretty -topic WordsWithCountsTopic > x $ cat x {"partition":0,"offset":0,"key":"","value":"1"}
|
hey misha! :) what a weird case - thanks for looking into it and providing a solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Felix :) Small fix for the tool, maybe some Windows users exist out there.
error was:
.\common.go:75: cannot use syscall.Stdout (type syscall.Handle) as type int in argument to terminal.IsTerminal
found solution here:
golang/go#12978 (comment)
tested both terminal and non terminal :)
$ ./kt consume -pretty -topic WordsWithCountsTopic
{
"partition": 0,
"offset": 0,
"key": "",
"value": "1"
}
$ ./kt consume -pretty -topic WordsWithCountsTopic > x
$ cat x
{"partition":0,"offset":0,"key":"","value":"1"}