Update to Ubuntu 20.04 and fix downloading LLVM from CI #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
Closed
pvdrz
approved these changes
Mar 8, 2024
Hoverbear
approved these changes
Mar 8, 2024
|
bors merge |
|
Build succeeded: |
bors-ferrocene bot
added a commit
that referenced
this pull request
Mar 11, 2024
383: Fix downloading tarballs from CI after the renaming r=Veykril a=pietroalbini In #342 we switched to a new tarball naming scheme, but we didn't update the bootstrap code that downloads them to use the new naming. This PR fixes that. Also, with this and #376 downloading LLVM from CI works again! I thus updated the docs to remove the need to disable CI-downloaded LLVMs. Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #283 and #362: it updates CI to run on Ubuntu 20.04 (fixing the failure in #305), and changes how we build LLVM to hopefully fix
download-ci-llvm. Notably, this bumps the minimum glibc version requirement to 2.31.The hard part of this PR was fixing the broken CI for Aarch64. It turns out that the failure was caused by a breaking change in
binfmt-supportpackage, which now requires manually enabling new binfmts after importing them (if/proc/sys/fs/binfmt_miscis not mounted, like in CI).