-
Notifications
You must be signed in to change notification settings - Fork 40
fix segfaulting rustc when download-ci-llvm = true
#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryBuild succeeded:
|
8608ff7
to
86c2e52
Compare
bors try |
tryBuild failed: |
86c2e52
to
1a8fed1
Compare
bors try |
tryBuild failed:
|
bors try |
tryBuild failed: |
9eca357
to
a2721a1
Compare
bors try |
tryBuild failed: |
download-ci-llvm = true
tshepang
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
we can get the directory (ubuntu-18) renamed (to ubuntu-20) in a future PR |
bors-ferrocene bot
added a commit
that referenced
this pull request
Feb 27, 2024
283: fix segfaulting rustc when `download-ci-llvm = true` r=tshepang a=japaric - the segfault occurred in the second / third C++ frame after `rustc` called into LLVM using the `PassWrapper.cpp` glue - the segfault occurred due a ABI mismatch between those two frames - both frames corresponded to LLVM C++ functions. (the first frame was the `PassWrapper.cpp` glue) - one of the frames (functions) came from the LLVM library built in CI; the other frame was codegen'd locally - when comparing to a rust-lang/rust build, it was found that both frames involved in the segfault were present in the LLVM library built in rust-lang/rust CI. the rust-lang/rust artifact did not result in a segfault - the differences between the rust-lang/rust and ferrocene build settings are: (a) rust-lang/rust builds llvm as shared library; ferrocene builds them as static libraries. (b) rust-lang/rust uses `clang` and a newer version of `gcc` / `g++` - building LLVM as shared libraries in ferrocene did not fix the segfault but additionally bumping the `gcc` / `g++` version (by way of using a newer base docker image) did Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
Build failed: |
bors retry |
bors-ferrocene bot
added a commit
that referenced
this pull request
Feb 28, 2024
283: fix segfaulting rustc when `download-ci-llvm = true` r=tshepang a=japaric - the segfault occurred in the second / third C++ frame after `rustc` called into LLVM using the `PassWrapper.cpp` glue - the segfault occurred due a ABI mismatch between those two frames - both frames corresponded to LLVM C++ functions. (the first frame was the `PassWrapper.cpp` glue) - one of the frames (functions) came from the LLVM library built in CI; the other frame was codegen'd locally - when comparing to a rust-lang/rust build, it was found that both frames involved in the segfault were present in the LLVM library built in rust-lang/rust CI. the rust-lang/rust artifact did not result in a segfault - the differences between the rust-lang/rust and ferrocene build settings are: (a) rust-lang/rust builds llvm as shared library; ferrocene builds them as static libraries. (b) rust-lang/rust uses `clang` and a newer version of `gcc` / `g++` - building LLVM as shared libraries in ferrocene did not fix the segfault but additionally bumping the `gcc` / `g++` version (by way of using a newer base docker image) did Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
Build failed:
|
This was referenced Mar 8, 2024
Closed
Superseded by #376. |
bors-ferrocene bot
added a commit
that referenced
this pull request
Mar 8, 2024
376: Update to Ubuntu 20.04 and fix downloading LLVM from CI r=pvdrz a=pietroalbini This PR is based on #283 and #362: it updates CI to run on Ubuntu 20.04 (fixing the failure in #305), and changes how we build LLVM to hopefully fix `download-ci-llvm`. Notably, this bumps the minimum glibc version requirement to 2.31. The hard part of this PR was fixing the broken CI for Aarch64. It turns out that the failure was caused by a breaking change in `binfmt-support` package, which now requires manually enabling new binfmts after importing them (if `/proc/sys/fs/binfmt_misc` is not mounted, like in CI). Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com> Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com> Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc
called into LLVM using thePassWrapper.cpp
gluePassWrapper.cpp
glue)clang
and a newer version ofgcc
/g++
gcc
/g++
version (by way of using a newer base docker image) did