Skip to content

Conversation

Veykril
Copy link
Contributor

@Veykril Veykril commented Jun 7, 2024

The output of these two tests does not contain any host specific strings, so there is no reason not to run these only on one target.

Copy link
Contributor

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

bors-ferrocene bot commented Jun 7, 2024

Build succeeded:

  • full

@bors-ferrocene bors-ferrocene bot merged commit f078d54 into main Jun 7, 2024
@bors-ferrocene bors-ferrocene bot deleted the lw-cli-target-tests-cc branch June 7, 2024 16:50
@github-actions github-actions bot added the backport:maybe PR candidate for backport label Jun 7, 2024
bors-ferrocene bot added a commit that referenced this pull request Jun 19, 2024
680: Enable compiler-arguments/target test on all platforms r=tshepang a=Veykril

Allows enabling the remaining target test after #679

709: `rustfmt`: Link style guide and embed config options r=Urhengulas a=Urhengulas



712: Stripped white line to avoid conflict, same as beta. r=Urhengulas a=Dajamante

#710

Co-authored-by: Lukas Wirth <lukas.wirth@ferrous-systems.com>
Co-authored-by: Johann Hemmann <johann.hemmann@ferrous-systems.com>
Co-authored-by: aissata <aimaiga2@gmail.com>
bors-ferrocene bot added a commit that referenced this pull request Jun 19, 2024
680: Enable compiler-arguments/target test on all platforms r=tshepang a=Veykril

Allows enabling the remaining target test after #679

Co-authored-by: Lukas Wirth <lukas.wirth@ferrous-systems.com>
@pietroalbini pietroalbini added backport:1.79 and removed backport:maybe PR candidate for backport backport:1.79 labels Jul 8, 2024
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
bors-ferrocene bot added a commit that referenced this pull request Aug 19, 2024
842: Backport to `release/1.79` r=pietroalbini a=github-actions[bot]

This PR backports the following PRs to the `release/1.79` branch:

* #679
* #681

Note that the automation failed to backport some PRs automatically. Check out the [backport:manual](https://github.com/ferrocene/ferrocene/pulls?q=is%3Apr+label%3Abackport%3Amanual) for a list of them.

849: Remove stale exceptions from requirements-traceability r=pietroalbini a=Veykril

If #842 lands, the two tests are in fact green in the matrix

Co-authored-by: Lukas Wirth <lukas.wirth@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants