-
Notifications
You must be signed in to change notification settings - Fork 40
Pull upstream master 2023 10 17 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested here rust-lang/rust#106425 (comment)
Fixes #114593 Needs FCP due to behavioural changes.
This is a pretty basic test but should spot any other platforms which are `#[cfg(unix)]` but not Unix and where the wait status representation is wrong. (And any actual Unix platforms where it's not as expected, but I don't think they exist.)
Worsify formatting as required by rustfmt.
Move tests into a module as demanded by tidy.
Make `IpAddr::to_canonical` and `IpV6Addr::to_canonical` stable, as well as const stabilize `Ipv6Addr::to_ipv4_mapped`. Newly stable API: impl IpAddr { // Now stable under `ip_to_canonical` const fn to_canonical(&self) -> IpAddr; } impl Ipv6Addr { // Now stable under `ip_to_canonical` const fn to_canonical(&self) -> IpAddr; // Already stable, this makes it const stable under // `const_ipv6_to_ipv4_mapped` const fn to_ipv4_mapped(&self) -> Option<Ipv4Addr> } These stabilize a subset of the following tracking issues: - rust-lang/rust#27709 - rust-lang/rust#76205
- uses TypeReader for resolving local/return ty to support case where function pointer is before another type in a compound type
- add new testcase for TypeVisitor on const-eval mutable ref check
and some other raw pointer shenanigans while we are at it
Signed-off-by: onur-ozkan <work@onurozkan.dev>
We don't need to run `fn update_submodule` on rust-analyzer as it's no longer a submodule. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Don't restrict it to lines that have `//` in them. This means it can be used in `Cargo.toml` files, for example.
As per https://github.com/rust-lang/rust/blob/master/src/doc/style-guide/src/cargo.md, which says: > Sort key names alphabetically within each section, with the exception > of the [package] section. And use tidy to enforce it.
To get GNU/Hurd support, so that CI of external repositories (e.g. getrandom) can build std.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
c6e6ecb added it to some of the compiler's crates, but avoided adding it to all of them to reduce bit-rot. This commit adds to more.
Rollup of 6 pull requests Successful merges: - #116754 (coverage: Several small cleanups in `spans`) - #116798 (Improve display of parallel jobs in rustdoc-gui tester script) - #116800 (Fix implied outlives check for GAT in RPITIT) - #116805 (Make `rustc_onunimplemented` export path agnostic) - #116808 (Add myself to smir triage) - #116811 (Preserve unicode escapes in format string literals when pretty-printing AST) r? `@ghost` `@rustbot` modify labels: rollup
Commit 8378487 from #114611 changed the location of an obligation deduplication step in `opt_normalize_projection_type`. This meant that deduplication stopped happening on one path where it was still necessary, causing a couple of drastic performance regressions. This commit moves the deduplication back to the old location. The good news is that #114611 had four commits and 8378487 was of minimal importance, so the perf benefits from that PR remain. Fixes #116780, #116797.
Fix a performance regression in obligation deduplication. Commit 8378487 from #114611 changed the location of an obligation deduplication step in `opt_normalize_projection_type`. This meant that deduplication stopped happening on one path where it was still necessary, causing a couple of drastic performance regressions. This commit moves the deduplication back to the old location. The good news is that #114611 had four commits and 8378487 was of minimal importance, so the perf benefits from that PR remain. Fixes #116780, #116797. r? `@compiler-errors`
Use tidy to enforce alphabetical dependency ordering I get annoyed when dependencies in `Cargo.toml` files are not in alphabetical order. The [style guide](https://github.com/rust-lang/rust/blob/master/src/doc/style-guide/src/cargo.md) agrees with me. There are ongoing efforts to provide linting/formatting of `Cargo.toml` files, e.g. rust-lang/rustfmt#5240, https://crates.io/crates/cargo-toml-lint, and https://github.com/TimonPost/cargo-toml-format. But it's far from clear what's the right approach. So this PR does something very simple: it uses the order checking already present in tidy. This allows incremental application of ordering, starting right now, and avoiding the need for any kind of all-at-once conversion. If we do end up using some more comprehensive `Cargo.toml` linting/formatting solution in the future, the `tidy-alphabetical` lines will be easy to remove. r? `@wesleywiser`
docs: add Rust logo to more compiler crates c6e6ecb added it to some of the compiler's crates, but avoided adding it to all of them to reduce bit-rot. This commit adds to more. r? `@GuillaumeGomez`
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 3) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
…rk-Simulacrum reorganize/refactor bootstrap codebase Currently, bootstrap stores everything on the root path, including very large modules, which makes things very hard to scale and adds too much complexity. This PR has the following objectives: - Improving scalability. - Making bootstrap source more understandable for the new contributors(or for everyone). - Improving the development experience and making maintenance easier for the bootstrap team. The new source structure: ``` . ├── defaults │ ├── README.md │ ├── config.codegen.toml │ ├── config.compiler.toml │ ├── config.dist.toml │ ├── config.library.toml │ └── config.tools.toml ├── mk │ └── Makefile.in ├── src │ ├── bin │ │ ├── main.rs │ │ ├── rustc.rs │ │ ├── rustdoc.rs │ │ └── sccache-plus-cl.rs │ ├── core │ │ ├── build_steps │ │ │ ├── check.rs │ │ │ ├── clean.rs │ │ │ ├── compile.rs │ │ │ ├── dist.rs │ │ │ ├── doc.rs │ │ │ ├── format.rs │ │ │ ├── install.rs │ │ │ ├── llvm.rs │ │ │ ├── mod.rs │ │ │ ├── run.rs │ │ │ ├── setup.rs │ │ │ ├── suggest.rs │ │ │ ├── synthetic_targets.rs │ │ │ ├── test.rs │ │ │ ├── tool.rs │ │ │ └── toolstate.rs │ │ ├── config │ │ │ ├── config.rs │ │ │ ├── flags.rs │ │ │ └── mod.rs │ │ ├── builder.rs │ │ ├── download.rs │ │ ├── metadata.rs │ │ ├── mod.rs │ │ └── sanity.rs │ ├── tests │ │ ├── builder.rs │ │ ├── config.rs │ │ └── setup.rs │ ├── utils │ │ ├── bin_helpers.rs │ │ ├── cache.rs │ │ ├── cc_detect.rs │ │ ├── channel.rs │ │ ├── dylib.rs │ │ ├── helpers.rs │ │ ├── job.rs │ │ ├── metrics.rs │ │ ├── mod.rs │ │ ├── render_tests.rs │ │ └── tarball.rs │ └── lib.rs ├── Cargo.lock ├── Cargo.toml ├── README.md ├── bootstrap.py ├── bootstrap_test.py ├── build.rs ├── configure.py └── download-ci-llvm-stamp ``` The next step involves: - Adding more doc-comments to the bootstrap internals (although we already have a decent amount, there is space for improvement). - Breaking large modules into smaller, more manageable modules. - Significantly increasing our unit test coverage (which is currently lacking). This PR should serve as an initial step to make the tasks above much more easier. r? Mark-Simulacrum
This commit is generated by `ferrocene/tools/pull-upstream/pull.sh`. The list of excluded files is defined in `.gitattributes`.
229ebeb
to
adc4bdd
Compare
pietroalbini
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue-\d+.rs
tests to have meaningful names (part 3) rust-lang/rust#116824rustc_onunimplemented
export path agnostic rust-lang/rust#116805spans
rust-lang/rust#116754DefiningAnchor::Bubble
from opaque wf check rust-lang/rust#116802Config::hash_untracked_state
callback rust-lang/rust#116731rustc_features
some more rust-lang/rust#116550review-requested
feature for rustbot rust-lang/rust#116776{IpAddr, Ipv6Addr}::to_canonical
rust-lang/rust#115955return
if the for semi which can coerce to the fn return type rust-lang/rust#115196Bytes::next
andBytes::size_hint
. rust-lang/rust#116775guaranteed_eq
rust-lang/rust#116760PatKind::Error
when an ADT const value has violation rust-lang/rust#116522BufRead
forVecDeque<u8>
rust-lang/rust#110604string_deref_patterns
feature rust-lang/rust#116741std::convert::TryFrom
doc rust-lang/rust#116594try_exists
returnOk(true)
for Windows Unix Sockets rust-lang/rust#116683Config::verify
rust-lang/rust#116635S-waiting-on-author
rust-lang/rust#116661OnceCell/Lock::try_insert()
rust-lang/rust#116540librustc_driver.so
with BOLT rust-lang/rust#116352bootstrap/Cargo.toml
rust-lang/rust#116603fadd
instruction rust-lang/rust#116591#[repr(transparent)]
if it isn't part of the public ABI rust-lang/rust#115439unwrap
s rust-lang/rust#116679SAFETY
block on the usage of unsafegetuid
rust-lang/rust#116577async fn
and return-positionimpl Trait
in trait rust-lang/rust#115822atomic_from_ptr
rust-lang/rust#115719backtrace-rs
buildscript instd
buildscript" rust-lang/rust#116705const_maybe_uninit_assume_init_read
rust-lang/rust#116233