Reconnect failed tab. #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a fan of the UI part of this. The tab item is not very easy to discover, plus this adds an almost always disabled item to the menu (which is also quite redundant for non ssh tabs). How about some overlay similar to search/resize with two buttons (reconnect, close)? |
|
@felixse sounds reasonable, will try to update this PR with new overlay changes |
3e1bcea to
1cdfd47
Compare
maxhora
commented
Mar 26, 2020
| </Button> | ||
| </StackPanel> | ||
| </controls:DropShadowPanel> | ||
| <controls:DropShadowPanel |
There was a problem hiding this comment.
@felixse New DropShadowPanel is wrapped into StackPanel along with overlay for Search.
|
@felixse replaced new context menus with two buttons overlay to reconnect or close failed tab. Please let me know if any further adjustments make sense, thanks! |
felixse
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jumptrading/FluentTerminal/issues/222
Overlay to reconnect/close tab; Shortcut to reconnect tab.