Skip to content

Fixed a memory leak with opening / closing windows. #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fixed a memory leak with opening / closing windows. #542

merged 1 commit into from
Oct 7, 2019

Conversation

peske
Copy link
Contributor

@peske peske commented Oct 7, 2019 •
edited
Loading

It fixes the part of https://github.com/jumptrading/FluentTerminal/issues/190 related to windows. It looks though that we still have a leak with opening / closing tabs.

Reference: https://stackoverflow.com/questions/42806422/c-sharp-uwp-new-view-memory-leak

@felixse
Copy link
Owner

felixse commented Oct 7, 2019

Nice 👍

@felixse felixse merged commit cbdf629 into felixse:master Oct 7, 2019
@peske peske deleted the ap/leaks branch October 8, 2019 08:47
@felixse felixse mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixse felixse felixse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peske @felixse