Quick command implementation #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixse
reviewed
Aug 5, 2019
felixse
reviewed
Aug 5, 2019
felixse
reviewed
Aug 5, 2019
felixse
reviewed
Aug 5, 2019
felixse
reviewed
Aug 5, 2019
felixse
reviewed
Aug 5, 2019
|
When I try to run the code in this PR I get an ArgumentException when I try to open the quick launch dialog. The exception is thrown in in the FluentTerminal.App.ViewModels.CommandItemViewModel constructor. It's getting passed a null command, possibly by FillCommandHistory. @peske: we can go through it during our meeting. I'll try to leave my settings and profiles as they are in case that's relevant. |
|
@mjs - the issue should be fixed now. Please let me know when you try. |
felixse
reviewed
Aug 8, 2019
| /// and the command words (<see cref="_commandWords"/>). I'm aware that the code is quite confusing, but it kinda | ||
| /// has to be... | ||
| /// </summary> | ||
| private void CalculateMatchPrivate(string[] lowercaseFilterWords) |
There was a problem hiding this comment.
I think we should move this out of the ViewModel at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.