-
Notifications
You must be signed in to change notification settings - Fork 67
resolves 1489 and 2175: enrich range object and simplify FunctionSpace #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
define Range and RangeBase provide is_range_v and is_filter_v to know whether we manipulate a range port feelpp to new Range
Enrich range object #1489 Enriched the range object by modifying the `nelements` function template in multiple files. Made changes to improve readability and removed unnecessary code.
Closed
disambiguate type(fix compilation)
Enrich range object #1489 The commit enriches the range object by adding support for a new template parameter and additional constructors. This allows the range object to work with a MeshStructured class, as well as support different types for the template parameter.
Enrich range object This commit adds the inclusion of the <variant> header in functionspace.hpp file. It also updates the typedefs local_interpolant_type and local_interpolants_type to use std::monostate instead of boost::none_t in functionspace.hpp and orthonormalpolynomialset.hpp files.
Enrich range object #1489 - Refactor code to use the `Range` object instead of `ext_elements_t` in the `buildGhostDofMapExtended` and `generateDofPoints` functions. - Update type aliases in the `FunctionSpace` class to use the new `Range` object. - Remove redundant functions `project` from `projectors.hpp`. - Update the `test_submesh.cpp` file to use the new `Range` object in the `test_submesh_view` test case.
use Range in toolboxes - Declare range_elements_type using Range template for mesh_type and MESH_ELEMENTS - Update rangeMeshElements() function to return Range<mesh_type, MESH_ELEMENTS> instead of elements_reference_wrapper_t<mesh_type> - Update the variable M_rangeMeshElements to be of type Range<mesh_type, MESH_ELEMENTS> instead of elements_reference_wrapper_t<mesh_type> Refactor Range objects for better functionality
Add utility classes and templates to get the element type contained in certain classes: - Added `element_type_helper` class to get the element type of `ObjectType` - Added `element_t` and `element_ptr_t` aliases to get the element type and element shared pointer type of `ObjectType` - Added specializations of `element_type_helper` for `FunctionSpaces` and `Meshes` - Added `elements_mesh`, `faces_mesh`, `facets_mesh`, `edges_mesh`, `parent_mesh`, and `trace_mesh` classes and their corresponding aliases and specializations to get the mesh type and mesh shared pointer type of different topological dimensions
Enrich range object #1489
test integrals on submeshes including normal Enrich range object #1489
…behavior enable ensemble computing #1825
improve cmake preset #2082 [ci skip]
fix MeshStructured issue
fix some python tests Enrich range object #1489
…feelpp into 1489-enrich-range-object
Enrich range object #1489
collision is skipped for now skip feelpp skip testsuite skip toolboxes skip mor
Enrich range object #1489 skip feelpp skip testsuite skip toolboxes skip mor
…ody) Enrich range object #1489
/cc @VLCeline /cc @vincentchabannes skip feelpp skip testsuite skip toolboxes skip mor
Enrich range object #1489
@vincentchabannes the PR is ready to be merged |
@@ -287,6 +287,7 @@ BOOST_AUTO_TEST_CASE( test_grad ) | |||
//-------------------------------------- | |||
// case 0 : same support | |||
executeTestGrad( "case0_elt", spacePch1, "Pch1", spaceNed1h, "Ned1h", rangeElements, e, e ); | |||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prudhomm why comment? These tests are important.
vincentchabannes
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.