Skip to content

Collision forces and associated testcases #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jan 26, 2023
Merged

Collision forces and associated testcases #1838

merged 24 commits into from
Jan 26, 2023

Conversation

prudhomm
Copy link
Member

@prudhomm prudhomm commented Apr 20, 2022 •
edited
Loading

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?
  • Have you written Doxygen comments in your contribution ?

@prudhomm prudhomm added this to the v110 milestone Apr 20, 2022
@vincentchabannes
Copy link
Member

@prudhomm it should go on feelpp/toolbox repo. There are already a lot of example with rigid_body/swimmer and I can't maintain all. We should select only few of them usefull for test

@prudhomm
Copy link
Member Author

@vincentchabannes there will be some cleanup but we need to have true testcases including collision where we verify the results automatically. I don't believe we have any checks on that matter.
Tests that are not checking anything will be moved butwe need to ensure the testing of toolbox features

@prudhomm prudhomm changed the title Rb testcases Collision forces and associated testcases Apr 20, 2022
@prudhomm
Copy link
Member Author

I have retitled the PR

@vincentchabannes
Copy link
Member

one case is enough, and naca testcase is not a collision test case.

@prudhomm
Copy link
Member Author

@VLCeline is the python wrapper fluid.cpp and fluid-remesh.py up to date in this branch or do you have changes still sitting on your gaya account ?

@prudhomm
Copy link
Member Author

one case is enough, and naca testcase is not a collision test case.

it will probably go in feelpp/toolboxes since it is not even in the paper

@VLCeline
Copy link
Collaborator

@VLCeline is the python wrapper fluid.cpp and fluid-remesh.py up to date in this branch or do you have changes still sitting on your gaya account ?

I have some changes on my gaya account.

@prudhomm prudhomm linked an issue May 21, 2022 that may be closed by this pull request
Support contact/repulsion forces #1807
Closed
VLCeline and others added 2 commits May 31, 2022 14:34
@VLCeline
Updating collision algorithms and
d336d16 
computation of execution time
#1836
/cc @prudhomm
skip feelpp skip toolboxes skip mor skip tests
@prudhomm
Merge branch 'develop' into rb_testcases
05b3c42
@prudhomm prudhomm modified the milestones: v110, v111 Jul 1, 2022
@VLCeline
Merge branch 'develop' into rb_testcases
7d56ca1
@VLCeline
Up collision algos
0e0cb8c 
skip feelpp skip toolboxes skip mor skip tests
@lberti
Copy link
Collaborator

lberti commented Nov 25, 2022

@prudhomm @VLCeline checks on this branch have failed.
Also, the branch seems outdated with respect to develop.
Is anyone working on fixing this or should I do it?

@prudhomm
Copy link
Member Author

I am not. Thank you for taking care of this

@prudhomm
Copy link
Member Author

@vincentchabannes could you review this PR ? the extra tests have been removed by @lberti
@VLCeline will add 2 testcases for the collision model

vincentchabannes
vincentchabannes requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@vincentchabannes vincentchabannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove .DStore and mv cases in rigid_body_paper_tests in moving_body directory (already exist)

VLCeline and others added 7 commits January 24, 2023 11:30
@VLCeline
Add collision testcases
32d369f 
#1836  #1837 #1839
skip CI
@lberti
delete DS_Store
fcad293
@VLCeline
Move testcases to moving_body
5e6d2c9 
Cleanup and organize testcases on  bodies moving in fluids #1839
skip CI
@VLCeline
Remove useless headers and change CMakeList
4d204eb 
 #1837 #1836
@VLCeline
Fix collision testcases
62b44ab 
#1837
skip feelpp skip tests skip toolboxes skip mor
@lberti
#1837 use target_include_directories instead of include_directories
74c0516 
skip feelpp skip tests skip toolboxes skip mor
@VLCeline
Fix collision tests
f034b6e 
#1837
skip feelpp skip tests skip toolboxes skip mor
@lberti
Copy link
Collaborator

lberti commented Jan 26, 2023

@vincentchabannes we have made the changes there were demanded. The buildkite check has passed as well.

@vincentchabannes
Copy link
Member

WARNING, this testcases can NOT be used with feelpp_toolbox_fluid executable or standard python script. Currently, we can use collision model only in python by using this kind of script python/pyfeelpp-toolboxes/tests/test_collision.py @lberti @VLCeline @prudhomm is it correct?

@vincentchabannes vincentchabannes merged commit aa27f22 into develop Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberti lberti lberti left review comments

@VLCeline VLCeline VLCeline left review comments

@vincentchabannes vincentchabannes vincentchabannes approved these changes

Assignees

@lberti lberti

@VLCeline VLCeline

Labels
component: pyfeelpp-toolboxes ✨ type:feature
Projects
Feel++
Status: Done
Milestone
v111
4 participants
@prudhomm @vincentchabannes @VLCeline @lberti