Skip to content

Conversation

metivett
Copy link
Member

@metivett metivett commented Mar 9, 2022

Replaces boost::filesystem with std::filesystem to reduce boost dependency.

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?
  • Have you successfully run the Feel++ testsuite with your changes locally?

@prudhomm
Copy link
Member

merged with develop
I will review this weekend

@prudhomm
Copy link
Member

@metivett this fails https://buildkite.com/feelpp/feelpp/builds/4323#283f4c92-8da0-4c22-9f1f-24a64793afbc/6-11239
I will check the dependencies asap
there is no one-to-one correspondence between boost::filesystem and std::filesystem so it may not be just switching boost:: to std::

@metivett
Copy link
Member Author

metivett commented Mar 28, 2022

@metivett this fails https://buildkite.com/feelpp/feelpp/builds/4323#283f4c92-8da0-4c22-9f1f-24a64793afbc/6-11239 I will check the dependencies asap there is no one-to-one correspondence between boost::filesystem and std::filesystem so it may not be just switching boost:: to std::

Indeed, that's why I had to adapt a few things in caeed9d.
However, I don't understand why we have the error: no namespace named 'filesystem' in namespace 'std' in buildkite, there should be such a namespace...

@prudhomm
Copy link
Member

@metivett it is probably a problem with the GCC version. We use clang but clang uses libstdc++ and I think that std::filesystem is available only in GCC9.
I have to check the dependency version on GCC

@prudhomm
Copy link
Member

@metivett I just checked and we use GCC 9. Also std::filesystem is properly defined for c++17 in GCC9
see eg /usr/include/c++/9/bits/fs_fwd.h
I will have a closer look, perhaps later today

@prudhomm
Copy link
Member

@metivett in the mean time you can start docker

docker run --rm -it ghcr.io/feelpp/feelpp-env:ubuntu-20.04

get your branch and compile to see what is going on

@github-actions
Copy link

Stale pull request message

@github-actions
Copy link

Stale pull request message

@vincentchabannes
Copy link
Member

@prudhomm this PR is ready.

@prudhomm prudhomm added this to the v111 milestone Oct 30, 2023
@prudhomm prudhomm changed the title Feature/stdfilesystem replace boost::filesystem by std::filesystem Oct 30, 2023
@prudhomm prudhomm mentioned this pull request Oct 30, 2023
72 tasks
@prudhomm prudhomm merged commit 9f2bc3a into develop Oct 30, 2023
@prudhomm prudhomm deleted the feature/stdfilesystem branch October 30, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants