-
Notifications
You must be signed in to change notification settings - Fork 12
modules: manifest creation and linker usage #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this overall, excellent work. While not urgent, I'd like to update the README to reflect the new linker usage, but this is for another PR.
a1fba59
to
ec44dd9
Compare
I have also updated the cue file. Please let me know if the spec is wrong @Gerg-L @eclairevoyant (I used the test |
Side-thought, we should have a specification for linkers, as we'd want every linker that works with hjem to implement the same API (e.g. so we can just assume in the service that the linker will have a |
I think the least alternative linkers could do is to understand what the current spec is, but it might be a good idea to document and version the linker spec somewhere. I'll try to catch this in my upcoming documentation PR. Currently preparing a NDG stylesheet for Hjem, we can probably prepare a markdown document alongside the new README. |
8005b2e
to
0ae775a
Compare
I restored the old manifest, so we might take a look at it later to ensure that we implement the full specification correctly. Additionally, I came up with way better manifest validation: instead of checking inside of the service, we now check for it during the
So that they may re-link their files. |
f4018e0
to
4ad7e62
Compare
Made a few readability changes (inverted the condition in |
ty nezia, seems to work great with my minimal testing |
Co-authored-by: éclairevoyant <848000+eclairevoyant@users.noreply.github.com>
Co-authored-by: Eman Resu <8693624+quatquatt@users.noreply.github.com>
4ad7e62
to
d1776d7
Compare
closes #10
This adds to previous work that has been done into the manifest branch. This implements:
/var/lib/hjem
, where they can be accessed between generations (this causes Hjem to have to manage its own state)diff
command in order to compare files and re-link if neededLet me know your thoughts, as I am unsure if I have successfully implemented everything that's needed (very likely not).