Skip to content

Added scala dev guide #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2022
Merged

Added scala dev guide #306

merged 2 commits into from
Jun 7, 2022

Conversation

ahlag
Copy link
Contributor

@ahlag ahlag commented May 30, 2022 •
edited
Loading

Signed-off-by: Chang Yong Lik theeahlag@gmail.com

Description

  • Added Scala Dev Guide for newcomers

How was this patch tested?

None

Does this PR introduce any user-facing changes?

User guide in docs/dev_guide (Similar to python_dev_guide.md)

@ahlag ahlag force-pushed the docs/scala-onboarding branch from f76a562 to 3c41b49 Compare June 1, 2022 13:14
@ahlag
Added scala guide
15cf72d 
Signed-off-by: Chang Yong Lik <theeahlag@gmail.com>
@ahlag ahlag force-pushed the docs/scala-onboarding branch from 3c41b49 to 15cf72d Compare June 1, 2022 13:15
@ahlag ahlag changed the title [WIP] Added scala guide Added scala dev guide Jun 1, 2022
xiaoyongzhu
xiaoyongzhu previously approved these changes Jun 1, 2022
View reviewed changes
@xiaoyongzhu xiaoyongzhu requested review from hangfei and jaymo001 June 1, 2022 16:12
@xiaoyongzhu
Copy link
Member

Thanks @ahlag !

@ahlag
Copy link
Contributor Author

ahlag commented Jun 2, 2022

@xiaoyongzhu
Can I ask you the following questions?

  1. Is there a scala style guide?
  2. Do you know how to execute a single test within and a single test suite? I have tried the following command but failed.
    sbt 'testOnly com.linkedin.feathr.offline.AnchoredFeaturesIntegTest.tesSWAWithPreprocessing'
    I have listed all the questions I have for you as TBD in the PR.

@xiaoyongzhu
Copy link
Member

@xiaoyongzhu Can I ask you the following questions?

  1. Is there a scala style guide?
  2. Do you know how to execute a single test within and a single test suite? I have tried the following command but failed.
    sbt 'testOnly com.linkedin.feathr.offline.AnchoredFeaturesIntegTest.tesSWAWithPreprocessing'
    I have listed all the questions I have for you as TBD in the PR.

I'm not super familiar with that part TBH. looping in @jaymo001 and @hangfei to chime in

hangfei
hangfei reviewed Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. Developer experience is one of the most critical things we should keep improving.

Thanks for your work!

@ahlag
Added style
a774e97 
Signed-off-by: Chang Yong Lik <theeahlag@gmail.com>
@ahlag
Copy link
Contributor Author

ahlag commented Jun 2, 2022

@hangfei
Ok done!

@hangfei hangfei merged commit bd3cdc6 into feathr-ai:main Jun 7, 2022
@ahlag ahlag deleted the docs/scala-onboarding branch June 7, 2022 12:54
bozhonghu pushed a commit that referenced this pull request Jun 8, 2022
@bobohu97
Merge branch 'main' into fcm_feathr_merge
d37d534 
* main:
  Code format with the right subfolders (#198)
  Added scala dev guide (#306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@hangfei hangfei hangfei approved these changes

@jaymo001 jaymo001 Awaiting requested review from jaymo001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahlag @xiaoyongzhu @hangfei