Skip to content

Add Scala SBT CI and Python CI #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 22, 2022
Merged

Add Scala SBT CI and Python CI #2

merged 18 commits into from
Feb 22, 2022

Conversation

xiaoyongzhumsft
Copy link
Contributor

No description provided.

@xiaoyongzhumsft
Copy link
Contributor Author

Add CI pipeline for sbt test:

image

@xiaoyongzhumsft xiaoyongzhumsft changed the title Add Scala SBT CI/CD Add Scala SBT CI Feb 19, 2022
@xiaoyongzhumsft xiaoyongzhumsft changed the title Add Scala SBT CI Add Scala SBT CI and Python CI Feb 19, 2022
@jaymo001
Copy link
Collaborator

Great work!
A few minor comments:

  1. Could you also squash the commits so it looks cleaner?
  2. I can see "1 successful check", I can see the "sbt test" result, but where can I find the "pytest" result?
  3. If the "sbt test" or "pytest" fails, how will the system react? Will it bock the PR?
    Thanks!

@xiaoyongzhumsft xiaoyongzhumsft marked this pull request as draft February 20, 2022 00:03
@xiaoyongzhumsft xiaoyongzhumsft marked this pull request as ready for review February 20, 2022 00:03
@xiaoyongzhumsft
Copy link
Contributor Author

Great work! A few minor comments:

  1. Could you also squash the commits so it looks cleaner?
  2. I can see "1 successful check", I can see the "sbt test" result, but where can I find the "pytest" result?
  3. If the "sbt test" or "pytest" fails, how will the system react? Will it bock the PR?
    Thanks!

Thanks for the time, and I've resolved the comments. You should see all the workflows now (for pytest and sbt test), but we might want to discuss the behaviors more (currently it covers basic testing).
RE if the test is failed - currently the merge will not be blocked, but will instead show a red cross to give basic flexibility for folks to choose whether it should be merged or not.

hangfei
hangfei reviewed Feb 22, 2022
View reviewed changes
hangfei
hangfei approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

Add a developer guide on how to use/setup this.(maybe next PR)

@hangfei
Copy link
Collaborator

hangfei commented Feb 22, 2022

squash and do not create a merge commit.(use 2nd option)

@xiaoyongzhumsft
Add CI pipeline for sbt test and pytest
e9f9961 
Add CI pipeline for `sbt test` and `pytest`

Add CI pipeline for `sbt test` and `pytest`

Add Scala SBT CI/CD

Add python workflow test, extend timeout to avoid time out errors
xiaoyongzhumsft and others added 13 commits February 21, 2022 19:20
@xiaoyongzhumsft xiaoyongzhumsft merged commit 55f25ea into main Feb 22, 2022
@xiaoyongzhumsft xiaoyongzhumsft deleted the snowmanmsft-patch-1 branch February 22, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangfei hangfei hangfei approved these changes

@jaymo001 jaymo001 Awaiting requested review from jaymo001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoyongzhumsft @jaymo001 @hangfei @Yuqing-cat