Skip to content

Bug fix - Fraud detection sample notebook chart error. #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jan 11, 2023
Merged

Bug fix - Fraud detection sample notebook chart error. #948

merged 26 commits into from
Jan 11, 2023

Conversation

loomlike
Copy link
Collaborator

@loomlike loomlike commented Jan 9, 2023 •
edited
Loading

Description

I found there's a bug in the model result graph at the Fraud Detection sample notebook
Fixes are:

  • to use ML model output probability instead of the prediction class label for precision/recall graph
  • change the chart label to be the correct ML model name

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

loomlike added 24 commits December 6, 2022 16:10
@loomlike
Update notebooks to use latest codes with extra notebook dependencies
889f291 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
wip. Remove azure cli package from extra dependencies
62d7509 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update fraud detection demo notebook and add test
83fc0ca 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
WIP debugging
5e6a6bc 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Merge branch 'main' into jumin/update_get_result_df_examples
c19b79f
@loomlike
Update notebooks
711090f 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
modify notebook test to go-around materialization issue
2c0eac1 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Change notebook parameter name to align with client argument
9531554 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update recommendation notebook
0c3d7ab 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update synapse example. Add azure-cli dependency to notebook dependen…
62e42c0 
…cies

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update data url constants to point the source github repo's raw files
b13733b 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
add dataset url constants to init.py
bb0372d 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update feature embedding notebook to use the original dataset from az…
94507ad 
…ure example github

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Add recommendation sample notebook test
a318cb4 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Merge branch 'main' into jumin/update_get_result_df_examples
783c658 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Fix numpy.bool deprecation error
c473374 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Change databricks cluster node size from Dv2 to DSv2
2044323 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Use Dv4 for databricks notebook test due to the limit of Dv2 quota at…
7b91b3e 
… US East 2

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Fix to use the supported vm size
bad967d 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
pin numpy to resolve conflict with pyspark
73f60de 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Add document intelligence sample notebook
c1f791a 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Update fraud detection sample
4795914 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Merge branch 'main' into jumin/update_get_result_df_examples
9752e93
@loomlike
Fix Precision/recall graph of the fraud detection sample notebook
9285479 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 9, 2023
xiaoyongzhu
xiaoyongzhu previously approved these changes Jan 10, 2023
View reviewed changes
@loomlike
Merge branch 'main' into jumin/fix_fraud_detection_chart
9d322da 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
@loomlike
Change wait for job to finish to be 5000 sec
12a29cc 
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
blrchen
blrchen previously approved these changes Jan 10, 2023
View reviewed changes
@loomlike loomlike dismissed stale reviews from blrchen and xiaoyongzhu via 9d322da January 10, 2023 16:52
@blrchen blrchen merged commit a923a9d into feathr-ai:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blrchen blrchen blrchen approved these changes

@jainr jainr jainr approved these changes

@xiaoyongzhu xiaoyongzhu xiaoyongzhu left review comments

@Yuqing-cat Yuqing-cat Awaiting requested review from Yuqing-cat

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loomlike @xiaoyongzhu @blrchen @jainr