Skip to content

Maven Package Version Configuration Fix #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

Yuqing-cat
Copy link
Collaborator

Signed-off-by: Yuqing Wei weiyuqing021@outlook.com

Description

Resolves #747 and fix FEATHR_MAVEN_VERSION not working.

  • Move logic to version.py as it is not a constant.
  • Update related lines in all 3 spark provider
  • Add configuration description in wiki.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
@Yuqing-cat Yuqing-cat requested a review from blrchen November 9, 2022 03:35
@Yuqing-cat Yuqing-cat added the safe to test Tag to execute build pipeline for a PR from forked repo label Nov 9, 2022
@Yuqing-cat Yuqing-cat linked an issue Nov 10, 2022 that may be closed by this pull request
4 tasks
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
@xiaoyongzhu xiaoyongzhu merged commit 2e32e88 into feathr-ai:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Feathr Maven Version Customization not functional [DOC] Add guidance on MAVEN_ARTIFACT_VERSION environment variable
3 participants