Skip to content

Conversation

OlivierBlanvillain
Copy link
Contributor

mvn compile now automatically reformats the entire codebase. They are also pugins available for Eclipse & IntelliJ, see https://github.com/google/google-java-format.

This PR is best reviewed commit by commit given that the 2nd one is an auto generated diff. The 3rd commit does some very light refactoring to make the code fit nicely in the 100 line width limit enforced by the formatter.

@OlivierBlanvillain OlivierBlanvillain changed the title Setup automatic code formatter using the the Google Java Style Setup automatic code formatter using the Google Java Style Oct 6, 2018
@OlivierBlanvillain
Copy link
Contributor Author

@featurecat @zsalch What do you think?

@featurecat
Copy link
Owner

useful, how does it get set up? whenever programmers compile the program, it runs?

@OlivierBlanvillain
Copy link
Contributor Author

Yes

@featurecat
Copy link
Owner

so cool!! I'll check it in then later today I'll start drafting a release for lizzie 0.6. any concerns? also I don't know why the PR for new texture was closed but I'm just going to merge the new textures from there.

@featurecat featurecat merged commit 4b3e9bf into featurecat:next Oct 6, 2018
@OlivierBlanvillain
Copy link
Contributor Author

@featurecat I think we've been merging things PR a bit too eagerly, for instance here I introduced a couple of bugs (such as using x twice here 4315383#diff-c51e6645e657a3c7c444daafb9ad21e0R941, one of the things that @zsalch fixed in #393...). I propose that from now on we don't merge anything until it has been properly reviewed and received a "LGTM" comment indicating that the reviewer is happy with the diff. What do you think?

@OlivierBlanvillain OlivierBlanvillain deleted the auto-format branch October 8, 2018 07:03
@zsalch
Copy link
Contributor

zsalch commented Oct 8, 2018

@OlivierBlanvillain
The automatically reformat is very good! I am already using it.
Recommended as a code standard for contributors to keep the code in the same style.
At the same time, we can also share a code style configuration file, such as Google Style Guides.

@featurecat
Copy link
Owner

sounds good sorry for checking in too quickly. I'll let you check in more things in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants